Fix PushStyleVar aliasing the caller's ImVec2 into the style; fix DebugNodeFontGlyph crash

This commit is contained in:
4DBug
2026-10-08 09:27:57 -05:00
parent 1dd48be9b8
commit 3fca191b86
5 changed files with 61 additions and 7 deletions
+1 -1
View File
@@ -1 +1 @@
[[12, "imgui.lua"], [13734, "imgui_demo.lua"], [14667, "imgui_demo_2.lua"], [17742, "imgui_demo_apps.lua"], [19001, "imgui_demo_tools.lua"], [20327, "imgui_demo_widgets.lua"], [22251, "imgui_docking.lua"], [25379, "imgui_dragdrop.lua"], [25671, "imgui_draw.lua"], [30859, "imgui_h.lua"], [33072, "imgui_impl_roblox.lua"], [33859, "imgui_impl_roblox_fonts.lua"], [34637, "imgui_internal.lua"], [37807, "imgui_tables.lua"], [42154, "imgui_tabs.lua"], [43321, "imgui_widgets.lua"], [51845, "imstb_rectpack.lua"], [52291, "imstb_textedit.lua"], [53532, "imstb_truetype.lua"], [56000, "imstd_minstdio.lua"]]
[[12, "imgui.lua"], [13741, "imgui_demo.lua"], [14674, "imgui_demo_2.lua"], [17749, "imgui_demo_apps.lua"], [19008, "imgui_demo_tools.lua"], [20334, "imgui_demo_widgets.lua"], [22258, "imgui_docking.lua"], [25386, "imgui_dragdrop.lua"], [25678, "imgui_draw.lua"], [30866, "imgui_h.lua"], [33079, "imgui_impl_roblox.lua"], [33866, "imgui_impl_roblox_fonts.lua"], [34644, "imgui_internal.lua"], [37814, "imgui_tables.lua"], [42161, "imgui_tabs.lua"], [43328, "imgui_widgets.lua"], [51852, "imstb_rectpack.lua"], [52298, "imstb_textedit.lua"], [53539, "imstb_truetype.lua"], [56007, "imstd_minstdio.lua"]]
+7 -3
View File
@@ -8855,7 +8855,11 @@ function ImGui.PushStyleVar(idx, val)
end
local var = g.Style[var_info.Key]
g.StyleVarStack:push_back(ImGuiStyleMod(idx, var))
g.Style[var_info.Key] = val
if type(val) == "number" then
g.Style[var_info.Key] = val
else -- copy into the style's own ImVec2: storing the caller's vector would alias it into the style forever
var.x = val.x; var.y = val.y
end
end
--- @param idx ImGuiStyleVar
@@ -19130,8 +19134,8 @@ function ImGui.DebugNodeFontGlyph(font, glyph)
ImGui.Text("Pos: (%.2f,%.2f)->(%.2f,%.2f)", glyph.X0, glyph.Y0, glyph.X1, glyph.Y1)
ImGui.Text("UV: (%.3f,%.3f)->(%.3f,%.3f)", glyph.U0, glyph.V0, glyph.U1, glyph.V1)
if glyph.PackId >= 0 then
local r = ImFontAtlasPackGetRect(font.OwnerAtlas, glyph.PackId)
if r then ImGui.Text("PackId: 0x%X (%dx%d rect at %d,%d)", glyph.PackId, r.w, r.h, r.x, r.y) end
local r = { uv0 = ImVec2(), uv1 = ImVec2() }
if font.OwnerAtlas:GetCustomRect(glyph.PackId, r) then ImGui.Text("PackId: 0x%X (%dx%d rect at %d,%d)", glyph.PackId, r.w, r.h, r.x, r.y) end
end
ImGui.Text("SourceIdx: %d", glyph.SourceIdx)
end